Draft
Conversation
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 257f2d6
18 interesting tests: 7 KNOWN, 7 SKIP, 4 flaky
Top 22 slowest tests (at least 2 minutes):
|
MarioCadenas
force-pushed
the
init-speed-improvements
branch
from
bcc9026 to
1fb43f8
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
init-speed-improvements
branch
from
1fb43f8 to
7599847
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
force-pushed
the
init-speed-improvements
branch
from
7599847 to
257f2d6
Compare
MarioCadenas
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pkosiec
reviewed
Mar 12, 2026
Member
pkosiec
left a comment
pkosiec
left a comment
There was a problem hiding this comment.
It's so fast now 🚀 awesome work! Just a few comments
| manualLabel = "Can't find it? Search by name..." | ||
| } | ||
| options = append(options, huh.NewOption(manualLabel, manualID)) | ||
| desc += " (showing first 500)" |
Member
There was a problem hiding this comment.
we should use len(fetcher.Items) here, right?
| // destDir and launches `npm ci` in the background. The caller should read the | ||
| // returned channel after copyTemplate to get the result. Returns nil if the | ||
| // template is not a Node.js project or npm is not available. | ||
| func startBackgroundNpmInstall(ctx context.Context, srcProjectDir, destDir, projectName string) <-chan error { |
Member
| err = huh.NewSelect[string](). | ||
| Title(title). | ||
| Description(fmt.Sprintf("%d apps found — type to filter", len(existingApps))). | ||
| Description(fmt.Sprintf("%d apps found — / to filter", len(existingApps))). |
Member
There was a problem hiding this comment.
I'm just thinking - maybe our filtering should work with an exact name? 🤔
Warehouses.GetByName
w.ServingEndpoints.GetByName()
etc.
EDIT: Ignore this comment - for Lakebase there's no such method 😞 so probably that's not worth to switch to such solution, especially that it expects an exact name AFAIK
|
|
||
| desc := fmt.Sprintf("%d available — / to filter", len(fetcher.Items)) | ||
| if fetcher.HasMore && !fetcher.Capped { | ||
| options = append(options, huh.NewOption("↓ Load more...", moreID)) |
Member
There was a problem hiding this comment.
Is it possible to somehow has the "Load more" option visible in the same way as the "/ to filter" instead of a need to go to the last item and load more projects?
Imagine that there's a "/ to filter, N to load more"
WDYT?
| err := huh.NewSelect[string](). | ||
| Title(title). | ||
| Description(fmt.Sprintf("%d available — type to filter", len(items))). | ||
| Description(fmt.Sprintf("%d available — / to filter", len(items))). |
Member
There was a problem hiding this comment.
E.g. "600 available" is quite confusing, because it's the items which we fetched, not the total count.
So maybe we should say:
%d available- when we know we fetched all pages already%d fetched - / to filter - N to load more(as per my last comment)
WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests